Skip to content

Time misalignment #2

Description

@serkansulun

The function "split_sequence_with_sentiment" is used to split sequences of annotations to create chunks with a length of 4. When the length of the complete sequence is not a multiple of 4, the remaining values are discarded.

When the MIDI is being split according to these annotation chunks, the discarded values are not taken into consideration, and this would cause a time-shift. When there are only negative or only positive values in a sequence, this is not a problem since the discarded values are at the end of each sequence. But when there are both positive and negative values within a sequence, the sequence is first split to include only positive or only negative values. The values are discarded from the end of these sub-sequences, and these locations are effectively in the middle of the complete sequence. This would certainly be a problem.

Please let me know if I'm missing something.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions