Skip to content

Refit embedded terminals when windows regain focus - #187

Closed
luckeyfaraday wants to merge 1 commit into
mainfrom
fix/terminal-refit-on-window-return
Closed

Refit embedded terminals when windows regain focus#187
luckeyfaraday wants to merge 1 commit into
mainfrom
fix/terminal-refit-on-window-return

Conversation

@luckeyfaraday

Copy link
Copy Markdown
Owner

Summary

  • refit and refresh active embedded terminals when the Electron window regains focus or visibility
  • reset the cached terminal size so PTY resize/SIGWINCH is resent after window restoration
  • keep the fix scoped to the React terminal mount, without CSS overrides or resize-event churn

Risk checks

Verification

  • npm run build
  • npm run test:electron
  • npm run test:chat
  • git diff --check

Manual smoke still recommended

  • open two terminal panes, switch away and back to Athena, verify both redraw
  • verify typing still goes to the previously focused pane
  • verify workspace tab switching still redraws TUI output

@luckeyfaraday

Copy link
Copy Markdown
Owner Author

Superseded by #190, which includes this fix and its regression coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant