Skip to content

Reflow terminal panes when a sibling is spawned #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luckeyfaraday wants to merge 1 commit into from
+15 −3
Closed

Reflow terminal panes when a sibling is spawned #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions client/src/rooms/CommandRoom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ export function CommandRoom({
const dragStartRef = useRef<{ id: string; x: number; y: number } | null>(null);
const dragTargetRef = useRef<string | null>(null);
const newMenuRef = useRef<HTMLDivElement | null>(null);
const stageRef = useRef<HTMLDivElement | null>(null);
const workspaceOrderKey = normalizeWorkspaceKey(workspace || "none");
const sessionIds = sessions.map((session) => session.id);
const sessionSignature = sessionIds.join("|");
Expand Down Expand Up @@ -133,6 +134,16 @@ export function CommandRoom({
const displayedTerminalSessions = activeMaximizedPaneId
? visibleSessions.filter((session) => session.id === activeMaximizedPaneId)
: visibleSessions;

// The native `resize: vertical` handle on a pane writes an inline height straight onto
// the DOM node, which React never manages and so never clears. That pinned height keeps
// a previously resized pane from shrinking when a sibling is spawned below it, so clear
// it whenever the visible pane set changes and let the grid re-tile every pane.
useEffect(() => {
stageRef.current?.querySelectorAll<HTMLElement>(".slotPane").forEach((pane) => {
pane.style.height = "";
});
}, [visibleSessionKey]);
const visibleAgentSessions = agentSessions.filter((session) => !deletedSessionKeys.has(agentSessionKey(session)));
const providerTabs = useMemo(() => {
const counts = new Map<SessionProviderFilter, number>([["all", visibleAgentSessions.length]]);
Expand Down Expand Up @@ -356,6 +367,7 @@ export function CommandRoom({

{activeTab === "terminals" ? (
<div
ref={stageRef}
className={[
"terminalStage embeddedStage slotTerminalStage",
activeMaximizedPaneId ? "hasMaximized" : "",
Expand Down
6 changes: 3 additions & 3 deletions client/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,8 +1086,8 @@ button:disabled { cursor: not-allowed; opacity: .48; }
gap: 10px;
}
.embeddedStage {
align-content: start;
grid-auto-rows: minmax(205px, auto);
align-content: stretch;
grid-auto-rows: minmax(0, 1fr);
overflow: auto;
overscroll-behavior: contain;
}
Expand Down Expand Up @@ -1130,7 +1130,7 @@ button:disabled { cursor: not-allowed; opacity: .48; }
background: var(--terminal);
}
.slotPane {
min-height: 205px;
min-height: 0;
resize: vertical;
transition: box-shadow 120ms ease, border-color 120ms ease, transform 90ms ease;
}
Expand Down