[chore] Trigger Pages deploy on release tag + manual only, not every push to main#344
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push: branches: [main]withpush: tags: ["v*"]in.github/workflows/pages.ymlworkflow_dispatch, not on every commit tomainrelease.yml:4-5Test Plan
actionlint .github/workflows/pages.yml— 0 issues introduced (pre-existing SC2015 shellcheck note at line 34 is unchanged)pages.ymlno longer triggers onpush: branches: [main]pages.ymltriggers onpush: tags: ["v*"]workflow_dispatchstill present as escape-hatchUnit tests pass (— N/A, no Go files changedmake test)Linter passes (— N/A, no Go files changedmake lint)E2E tests pass (— N/A, no Go files changedmake test-e2e)Issue
Closes #343