Repository navigation
fix(DEF-019): bloquear pedidos de un carrito vacio - #46
Merged
Merged
Conversation
create_order usaba cart['total'] sin verificar que el carrito tuviera productos, permitiendo generar un pedido a partir de un carrito vacio (la creacion de carritos ya rechazaba productos=[] desde el fix de CP-24, pero un carrito vacio podia existir igual, ej. insertado directo en Mongo). Ahora create_order responde 400 si cart.productos esta vacio. Cierra CP-23 (pedido de carrito vacio bloqueado).
El default de FLASK_API en middleware.ts y astro.config.mjs cambio de localhost a 127.0.0.1, pero las aserciones del test seguian esperando localhost:5000, rompiendo test:coverage en CI.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_order usaba cart['total'] sin verificar que el carrito tuviera productos, permitiendo generar un pedido a partir de un carrito vacio (la creacion de carritos ya rechazaba productos=[] desde el fix de CP-24, pero un carrito vacio podia existir igual, ej. insertado directo en Mongo). Ahora create_order responde 400 si cart.productos esta vacio.
Cierra CP-23 (pedido de carrito vacio bloqueado).
Close #32