Skip to content

fix: update both Logback modules to 1.6.1 - #70

Merged
luisleineweber merged 1 commit into
mainfrom
ll/align-logback
Oct 1, 2026
Merged

luisleineweber merged 1 commit into
mainfrom
ll/align-logback

Conversation

@luisleineweber

Copy link
Copy Markdown
Owner

Summary

Update Logback Classic and Core together from 1.5.6 to 1.6.1. This combined update replaces #66 and #67.

Problem

The separate updates use different Logback versions. The server startup test fails with NoClassDefFoundError: ResourceAction for #67 and NoSuchMethodError: EnvUtil.logbackVersion() for #66. Both failures were reproduced with the existing startup test.

Solution

Use one logback.version property for both modules. Add a Dependabot group for their scheduled version updates so they enter one PR. See the GitHub group settings.

Validation

The existing startup test passes with both modules at 1.6.1. mvn -B package passes all 115 tests, meets the JaCoCo coverage gate, and builds the JAR. mvn -B dependency:tree -Dincludes=ch.qos.logback:* confirms that both modules resolve to 1.6.1. Local checks used JDK 24 with Java 21 as the compile target.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: eab9d114-0947-487b-8f9b-2cf07f8c5419

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@luisleineweber
luisleineweber marked this pull request as ready for review October 1, 2026 10:48
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@luisleineweber
luisleineweber merged commit 34ee7a1 into main Oct 1, 2026
2 checks passed
@luisleineweber
luisleineweber deleted the ll/align-logback branch October 5, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant