Repository navigation
fix: update both Logback modules to 1.6.1 - #70
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
luisleineweber
marked this pull request as ready for review
October 1, 2026 10:48
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Logback Classic and Core together from 1.5.6 to 1.6.1. This combined update replaces #66 and #67.
Problem
The separate updates use different Logback versions. The server startup test fails with
NoClassDefFoundError: ResourceActionfor #67 andNoSuchMethodError: EnvUtil.logbackVersion()for #66. Both failures were reproduced with the existing startup test.Solution
Use one
logback.versionproperty for both modules. Add a Dependabot group for their scheduled version updates so they enter one PR. See the GitHub group settings.Validation
The existing startup test passes with both modules at 1.6.1.
mvn -B packagepasses all 115 tests, meets the JaCoCo coverage gate, and builds the JAR.mvn -B dependency:tree -Dincludes=ch.qos.logback:*confirms that both modules resolve to 1.6.1. Local checks used JDK 24 with Java 21 as the compile target.