Skip to content

Fix FastMCP tool registration #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lukacf wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix FastMCP tool registration #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/goldfish/daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,8 +484,9 @@ def _register_tools(self) -> None:

from goldfish.server import mcp

# Get all registered tools from FastMCP (3.x uses async _list_tools)
tools = asyncio.run(mcp._list_tools())
# Use FastMCP's context-free middleware entrypoint. Calling
# _list_tools() directly requires a request context in FastMCP 2.13+.
tools = asyncio.run(mcp._list_tools_middleware())
for tool in tools:
self.tools[tool.name] = tool.fn
logger.debug("Registered tool: %s", tool.name)
Expand Down
4 changes: 3 additions & 1 deletion src/goldfish/mcp_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,9 @@ def _register_proxy_tools() -> None:

from goldfish.server import mcp as original_mcp

tools = asyncio.run(original_mcp._list_tools())
# Use FastMCP's context-free middleware entrypoint. Calling _list_tools()
# directly requires a request context in FastMCP 2.13+.
tools = asyncio.run(original_mcp._list_tools_middleware())
for tool in tools:
tool_name = tool.name
original_fn = tool.fn
Expand Down
Loading