Dev/kirisamejin/support file list and get - #32
Merged
Conversation
Contributor
Author
|
应该还得在agent和agentcentral加上test |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 41.96% 37.55% -4.41%
==========================================
Files 88 89 +1
Lines 2414 2809 +395
==========================================
+ Hits 1013 1055 +42
- Misses 1339 1684 +345
- Partials 62 70 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dxyinme
reviewed
Jul 23, 2025
| --fileservicefe, --no-fileservicefe | ||
| build fileservicefe (default: False) | ||
|
|
||
| ./tools/testscripts/devstart.sh |
Member
There was a problem hiding this comment.
这个最好新开一个section，然后写个什么 dev env 启动之类的title
dxyinme
reviewed
Jul 23, 2025
|
|
||
| type FileListRequest struct { | ||
| OperationId string | ||
| Node string `json:"nodes"` |
dxyinme
reviewed
Jul 23, 2025
| ah.responsesMutex.Lock() | ||
| delete(ah.pendingFileGetOps, operationId) | ||
| ah.responsesMutex.Unlock() | ||
| return nil, fmt.Errorf("timeout waiting for response") |
dxyinme
reviewed
Jul 23, 2025
|
|
||
| func (ah *agentHolder) AddFileListRequest(operationId, path string) error { | ||
| ah.fileRequestsMutex.Lock() | ||
| defer ah.fileRequestsMutex.Unlock() |
Member
There was a problem hiding this comment.
这里是不是可以不用defer, append成功就可以unlock了
Contributor
Author
There was a problem hiding this comment.
我想了一下（虽然这个代码也是AI写的），如果append之后unlock，这个时候pendingFileListOps还没加上，就可以addRequestToHB，然后再下一次HB返回的时候如果还没加上，就会找不到对应的pendingFileListOps。但应该不会出现这种情况。
dxyinme
reviewed
Jul 23, 2025
| // Add file operation request queues | ||
| fileListRequests []models.FileListRequest | ||
| fileGetRequests []models.FileGetRequest | ||
| fileRequestsMutex sync.Mutex |
Member
There was a problem hiding this comment.
fileListRequests和fileGetRequests为啥共用同一个锁
Member
确实得加，不加coverage太低了 |
dxyinme
reviewed
Jul 23, 2025
dxyinme
reviewed
Aug 24, 2025
| s.fakeFileServer.AddFileContent(path.Join("TestPublicFileDownload", "a.txt"), content) | ||
| url := fakefileserver.BuildDownloadURL(s.fakeFileServer, path.Join("TestPublicFileDownload", "a.txt")) | ||
| // Use forward slashes for URL paths, not path.Join which uses OS-specific separators | ||
| serverPath := "TestPublicFileDownload/a.txt" |
Member
|
其他都OK，就加点test就行 |
…ithub.com/lukaproject/Linda into dev/kirisamejin/support-file-list-and-get
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22