Open
Conversation
Vec<...> never stopping with empty value
There was a problem hiding this comment.
Pull Request Overview
Adds a regression test to ensure deserializing into Vec properly terminates when no matching items are present, preventing non-terminating behavior.
- Introduces a new tests::bugs module
- Adds a not_stopping test validating Vec deserialization stops and yields an empty vector on non-matching content
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| xmlity-quick-xml/tests/features.rs | Exposes the new bugs test module so it’s compiled and run. |
| xmlity-quick-xml/tests/bugs/not_stopping.rs | Adds the regression test and minimal types needed to reproduce the issue. |
| xmlity-quick-xml/tests/bugs/mod.rs | Declares the not_stopping test submodule. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.