Conversation
| @@ -0,0 +1,28 @@ | |||
| <component name="ProjectCodeStyleConfiguration"> | |||
There was a problem hiding this comment.
ten plik i reszta z .idea do gitignore
| @@ -0,0 +1,13 @@ | |||
| ---------------------------------------------------------------- | |||
Comment on lines
+23
to
+31
| <dependency> | ||
| <groupId>com.h2database</groupId> | ||
| <artifactId>h2</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.derby</groupId> | ||
| <artifactId>derby</artifactId> | ||
| <scope>runtime</scope> | ||
| </dependency> |
Comment on lines
+53
to
+57
| <dependency> | ||
| <groupId>org.springframework.hateoas</groupId> | ||
| <artifactId>spring-hateoas</artifactId> | ||
| <version>0.25.1.RELEASE</version> | ||
| </dependency> |
| @AllArgsConstructor | ||
| @NoArgsConstructor | ||
| @Entity | ||
| @Table(name = "BILL") |
| Bill bill = billMapper.toModel(billDTO); | ||
| bill.setBillId(billId); | ||
| bill.setParking(getParkingById(billDTO.getParking().getParkingId())); | ||
| bill.setClient(getClientById(billDTO.getClient().getClientId())); |
There was a problem hiding this comment.
użycie buildera mogłoby tu troszkę lepiej wyglądać, ale to preferencja
| return clientMapper.toDTO(addedClient); | ||
| } | ||
|
|
||
| private void checkIfClientExist(ClientDTO clientDTO) { |
There was a problem hiding this comment.
Nazwa trochę myli, bo sprawdzasz czy istnieje email a nie klient
| return clientMapper.toDTO(addedClient); | ||
| } | ||
|
|
||
| private boolean isThisClientOnRepo(UUID clientId) { |
There was a problem hiding this comment.
nazwa mogłaby być krótsza, np. clientExists()
| BigDecimal nextHoursCharge; | ||
|
|
||
| long periodOnParkingInMillis = calculateTimeSpent(parkingDate); | ||
| System.out.println("time spend przed zaokrogleniem " + periodOnParkingInMillis); |
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| class ClientTest { | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.