fix(dep-check): replace overly broad exception handling in main.py#130
Open
pshariat wants to merge 1 commit into
Open
fix(dep-check): replace overly broad exception handling in main.py#130pshariat wants to merge 1 commit into
pshariat wants to merge 1 commit into
Conversation
Replace try/except KeyError blocks with explicit feature validation to prevent masking runtime errors with misleading "invalid feature" error messages.
noirbee
approved these changes
Feb 17, 2026
Comment on lines
+140
to
+141
| if self.feature not in DEP_CHECK_FEATURES: | ||
| raise MissingOptionError() |
Contributor
There was a problem hiding this comment.
How would this ever run if it's checked in the __init__ already ?
Contributor
There was a problem hiding this comment.
Not sure this particular bug / piece of code is worth all these tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing an issue where dependency check errors would be returned as MissingOptionErrors.
Ex:
The actual issue was that dependency_config.yaml was malformed: the MissingOptionError was very confusing.