feat(vue): create select button component#1655
Merged
Merged
Conversation
gcornut
force-pushed
the
feat/vue_create_select_button_component
branch
2 times, most recently
from
c2de7a2 to
504ceeb
Compare
gcornut
changed the base branch from
master
to
feat/select_text_field_fallback_on_option_name_on_custom_option
gcornut
force-pushed
the
feat/vue_create_select_button_component
branch
4 times, most recently
from
5c9b6f2 to
72c550b
Compare
Base automatically changed from
feat/select_text_field_fallback_on_option_name_on_custom_option
to
master
May 7, 2026 13:36
gcornut
force-pushed
the
feat/vue_create_select_button_component
branch
2 times, most recently
from
4f7577b to
4d97d93
Compare
gcornut
force-pushed
the
feat/vue_create_select_button_component
branch
from
4d97d93 to
a0bc959
Compare
gcornut
force-pushed
the
feat/vue_create_select_button_component
branch
2 times, most recently
from
cd1a26d to
ba7c416
Compare
gcornut
force-pushed
the
feat/vue_create_select_button_component
branch
from
ba7c416 to
30b104f
Compare
Visual Regression Report@lumx/react — 15 difference(s)@lumx/vue — 18 new@lumx/react vs @lumx/vue — 1 difference(s), 451 matched, 123 React-only, 3 Vue-only |
durellinux
reviewed
May 21, 2026
| const setButtonRef = (el: any) => { | ||
| buttonRef.value = (el?.$el ?? el) as HTMLElement | null; | ||
| }; | ||
| expose({ |
There was a problem hiding this comment.
@andrzej-augustyniak I have no idea what this does... is it reactive written this way? And in general do we really care if this is reactive or not?
durellinux
reviewed
May 21, 2026
|
|
||
| // Otherwise wrap in span | ||
| return <span>{children}</span>; | ||
| return <span>{visibleChildren}</span>; |
There was a problem hiding this comment.
What can be the children here? Can we wrap them always in a span?
Member
Author
There was a problem hiding this comment.
We do not really support anything else than text in button content for now
durellinux
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General summary
Migrate SelectButton to vue
StoryBook lumx-react: https://349d7813b--5fbfb1d508c0520021560f10.chromatic.com/
StoryBook lumx-vue: https://349d7813b--697a023f84e832e23544fb3c.chromatic.com/