feat(react): create TimePickerField component#1657
Merged
Conversation
gcornut
force-pushed
the
feat/react_create_time_picker_field_component
branch
from
8b3d8a1 to
77a7822
Compare
gcornut
force-pushed
the
feat/react_create_time_picker_field_component
branch
from
77a7822 to
40debd4
Compare
gcornut
force-pushed
the
feat/react_create_time_picker_field_component
branch
3 times, most recently
from
a3fb964 to
304da32
Compare
gcornut
force-pushed
the
feat/react_create_time_picker_field_component
branch
from
304da32 to
7e55f87
Compare
gcornut
force-pushed
the
feat/react_create_time_picker_field_component
branch
from
7e55f87 to
6e4efb4
Compare
juanigalan91
approved these changes
May 25, 2026
Contributor
juanigalan91
left a comment
juanigalan91
left a comment
There was a problem hiding this comment.
Looks good!
I've also tested it and we can select times as well as entering a custom one
gcornut
force-pushed
the
feat/react_create_time_picker_field_component
branch
from
6e4efb4 to
9cb13db
Compare
Visual Regression Report@lumx/react — 3 difference(s), 7 new@lumx/vue — 1 difference(s)@lumx/react vs @lumx/vue — 1 difference(s), 451 matched, 130 React-only, 3 Vue-only |
Member
Author
|
Test OK ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CF-1403
General summary
Create a time picker field based on a SelectTextField with generated time suggestions, with min/max times and with parsing of user entered time
StoryBook lumx-vue: https://eed80a613--697a023f84e832e23544fb3c.chromatic.com/
StoryBook lumx-react: https://eed80a613--5fbfb1d508c0520021560f10.chromatic.com/