Repository navigation
fix: improve TURN relay failover - #30
Merged
Merged
Conversation
mrddt-tech
marked this pull request as ready for review
September 7, 2026 08:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Workers converged on the first TURN URL. A relay that accepted Allocate but returned no peer traffic could delay configuration and make healthy relays underused.
Root cause
Relay selection was first-available rather than per-worker, retries did not rotate relays, and concurrent Allocate calls could burst across groups. A credential refresh path also attempted to reacquire its own lock.
Implementation
Tests
cd core && go test ./...Observed behavior
With a silent relay, configuration was obtained through healthy relays promptly and workers spread across relays. Failover is relay-specific; it does not indicate an invalid connection password.
Trade-offs
The three config racers intentionally trade a small amount of duplicate startup work for resilience to a silent relay. Allocation pacing is scoped to one Core instance.