Working version radu #1

RaduLeabu-coding · 2025-10-28T14:34:21Z

No description provided.

…stable one) to not have 10K+ changes

- add parsing for special chars - add links to actual PDP page - format response in a friendly UI

…al endpoints - Add nlweb site configuration, disable tool_selection and who_endpoint - Add nlweb site definition

…ackend'

…pping tool selection, auto-select search tool with score 100

…hen who_endpoint_enabled is false, use sites from config

…web, extract fields from source_url and schema_org

-Set default site to 'nlweb', mode to 'summarize', db to 'qdrant_url' -Update default values in state initialization

RaduLeabu-coding · 2025-10-28T14:35:16Z

From any of this changes do you see anything that can cause problems when deploying to an app service on azure ?

Copilot

Pull Request Overview

This PR configures the application for furniture search functionality using the nlweb site with Qdrant vector database, defaulting to "summarize" mode for improved user experience with formatted responses and product links.

Switches default configuration from Azure/Bing to Qdrant URL endpoint for nlweb furniture database
Updates UI to default to "summarize" mode with enhanced formatting for product summaries
Adds content formatter for cleaning HTML entities and extracting product links from search results

Reviewed Changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
static/index.html	Sets default parameters for nlweb site with summarize mode
static/common-chat-styles.css	Adds CSS for formatted summaries and product links display
static/chat-ui-common.js	Implements markdown parsing and product links rendering
static/chat-interface-unified.js	Changes defaults to nlweb/summarize and adds mode change notifications
start_server_debug.py	Fixes server class name capitalization
config/sites.xml	Adds nlweb site configuration for furniture database
config/config_retrieval.yaml	Switches from local to URL-based Qdrant endpoint
config/config_nlweb.yaml	Configures nlweb site and disables tool/who endpoints
config/config_llm.yaml	Updates API version and model references
config/config_embedding.yaml	Updates API version to use environment variable
code/python/webserver/routes/api.py	Maps UI "mode" parameter to backend "generate_mode"
code/python/testing/connectivity/check_connectivity.py	Adds dotenv import (commented out)
code/python/testing/check_connectivity.py	Adds dotenv import (commented out)
code/python/retrieval_providers/qdrant.py	Updates result formatting for nlweb data structure
code/python/methods/multi_site_query.py	Adds support for disabled who endpoint with direct site configuration
code/python/core/utils/content_formatter.py	New formatter for cleaning HTML entities and extracting product links
code/python/core/router.py	Auto-selects search tool for summarize/generate modes
code/python/core/retriever.py	Adds "retrieval" parameter support for endpoint selection
code/python/core/ranking.py	Skips individual result sending in summarize/generate modes
code/python/core/post_ranking.py	Enhances summary formatting with product links
code/python/core/baseHandler.py	Improves mode parameter handling from UI
code/python/app-file.py	Adds commented dotenv import
code/python/app-aiohttp.py	Adds commented dotenv import
UI_MOCKUP.md	Documentation of UI improvements
SUMMARY_UI_IMPROVEMENTS.md	Detailed summary of UI enhancement changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-28T14:36:17Z

config/config_retrieval.yaml

    api_key_env: QDRANT_API_KEY
    # Set the collection name to use
-    index_name: nlweb_collection
+    index_name: QDRANT_COLLECTION


The index_name is set to 'QDRANT_COLLECTION' which appears to be an environment variable placeholder rather than an actual collection name. This should either reference an environment variable using the index_name_env key, or be set to a literal collection name like 'nlweb_collection'.

Suggested change

index_name: QDRANT_COLLECTION

index_name_env: QDRANT_COLLECTION

Copilot · 2025-10-28T14:36:18Z

code/python/retrieval_providers/qdrant.py

+            schema_org = payload.get("schema_org", {})
+            if isinstance(schema_org, dict):
+                # If it's already a dict, convert to JSON string
+                import json


Import statements should be placed at the top of the file, not inside a method. Move this import to the module-level imports section.

Suggested change

import json

Copilot · 2025-10-28T14:36:18Z

code/python/core/utils/content_formatter.py

@@ -0,0 +1,136 @@
+import re


The file contains a UTF-8 BOM (Byte Order Mark) character at the beginning. This invisible character can cause syntax errors in Python. Remove the BOM by re-saving the file with UTF-8 encoding without BOM.

Suggested change

import re

import re

Copilot · 2025-10-28T14:36:18Z

code/python/methods/multi_site_query.py

+                                    'query': self.query
+                                }
+
+


Extra blank line should be removed to maintain consistent code formatting.

Suggested change

Copilot · 2025-10-28T14:36:19Z

code/python/core/post_ranking.py

@@ -21,12 +21,15 @@ async def do(self):
        await self.check_and_send_map_message()

        if (self.handler.generate_mode == "none"):


[nitpick] The comment '# nothing to do' was removed. While the code is clear, the comment provided useful documentation about the intent when generate_mode is 'none'. Consider restoring it for clarity.

Suggested change

if (self.handler.generate_mode == "none"):

if (self.handler.generate_mode == "none"):

# nothing to do

RaduLeabu-coding · 2025-10-28T14:41:24Z

From any of this changes do you see anything that can cause problems when deploying to an app service on azure ?

Copilot

Pull Request Overview

Copilot reviewed 25 out of 26 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-28T14:45:50Z

start_server_debug.py

    """Run server with debug output."""
    print("Starting server with debug output...")
-    server = AioHttpServer(CONFIG)
+    server = AioHTTPServer()


The AioHTTPServer constructor is being called without arguments, but the original code passed CONFIG as a parameter. This change may cause initialization issues if the server class expects configuration to be provided during instantiation.

Suggested change

server = AioHTTPServer()

server = AioHTTPServer(CONFIG)

Copilot · 2025-10-28T14:45:51Z

code/python/retrieval_providers/qdrant.py

+            schema_org = payload.get("schema_org", {})
+            if isinstance(schema_org, dict):
+                # If it's already a dict, convert to JSON string
+                import json


The import json statement is placed inside a method rather than at the module level. This should be moved to the top of the file with other imports for better performance and code organization.

Suggested change

import json

Copilot · 2025-10-28T14:45:51Z

code/python/retrieval_providers/qdrant.py

+            else:
+                # If it's already a JSON string, use as-is
+                schema = str(schema_org)
+                name = payload.get("text", "").split("|")[0].replace("Name: ", "").strip() if payload.get("text") else ""


This complex one-liner with chained string operations and conditionals is difficult to read and maintain. Consider breaking this into multiple lines with intermediate variables for clarity.

Suggested change

name = payload.get("text", "").split("|")[0].replace("Name: ", "").strip() if payload.get("text") else ""

text_value = payload.get("text", "")

if text_value:

name_part = text_value.split("|")[0]

name = name_part.replace("Name: ", "").strip()

else:

name = ""

Copilot · 2025-10-28T14:45:51Z

code/python/methods/multi_site_query.py

+
+

[nitpick] Empty line serves no purpose in the code flow. Remove this blank line to improve code cleanliness.

Suggested change

…ploy

…lt formatting product → schema_json (with JSON conversion)

RaduLeabu-coding added 14 commits October 26, 2025 15:53

Add .venv in git ignore after changing python version from 14 to 12 (…

4741486

…stable one) to not have 10K+ changes

Add UI improvements:

67ea777

- add parsing for special chars - add links to actual PDP page - format response in a friendly UI

Add force loading for env file

66c149c

- Switch write_endpoint to qdrant_url, enable qdrant_url, disable loc…

229cdf7

…al endpoints - Add nlweb site configuration, disable tool_selection and who_endpoint - Add nlweb site definition

Fix API version references; Use env var AZURE_OPENAI_API_VERSION

9495070

Add support for 'retrieval' parameter alongside 'db' and 'retrieval_b…

d84f31c

…ackend'

Map 'mode' parameter to 'generate_mode' for backward compatibility

69dad66

Auto-select search tool for summarize/generate modes - Instead of ski…

7156301

…pping tool selection, auto-select search tool with score 100

Multi-site query without who endpoint - Support multi-site queries w…

8d0ac6d

…hen who_endpoint_enabled is false, use sites from config

Qdrant result formatting for nlweb data - Skip site filtering for nl…

e7ed9d3

…web, extract fields from source_url and schema_org

UI defaults for furniture search:

f775088

-Set default site to 'nlweb', mode to 'summarize', db to 'qdrant_url' -Update default values in state initialization

Fix import typo AioHttpServer → AioHTTPServer, fix initialization

a334f20

final stable version - fix generate and summarize mode

11eff7d

azure setup - env

13124af

RaduLeabu-coding requested a review from Copilot October 28, 2025 14:34

RaduLeabu-coding self-assigned this Oct 28, 2025

Copilot AI reviewed Oct 28, 2025

View reviewed changes

RaduLeabu-coding requested a review from Copilot October 28, 2025 14:44

Copilot AI reviewed Oct 28, 2025

View reviewed changes

RaduLeabu-coding added 7 commits October 29, 2025 02:11

Fix: rename code/python/requirements -> requirements.txt for Azure de…

55a933e

…ploy

Normalize startup.sh to LF (disable CRLF conversions)

a833315

Add .gitattributes to enforce LF line endings

bad19d4

"Add .gitattributes to enforce LF line endings for Azure Linux deploy"

26309ca

startup: robust server start with fallback and minimal aiohttp app

d128343

FIx Field mapping mismatch between stored Qdrant data and search resu…

e05dda5

…lt formatting product → schema_json (with JSON conversion)

Add authentication

f3ff4a0

	index_name: QDRANT_COLLECTION
	index_name_env: QDRANT_COLLECTION

		@@ -21,12 +21,15 @@ async def do(self):
		await self.check_and_send_map_message()

		if (self.handler.generate_mode == "none"):

	if (self.handler.generate_mode == "none"):
	if (self.handler.generate_mode == "none"):
	# nothing to do

-                name = payload.get("text", "").split("|")[0].replace("Name: ", "").strip() if payload.get("text") else ""
+                text_value = payload.get("text", "")
+                if text_value:
+                    name_part = text_value.split("|")[0]
+                    name = name_part.replace("Name: ", "").strip()
+                else:
+                    name = ""

Working version radu #1

Are you sure you want to change the base?

Working version radu #1

Uh oh!

Conversation

RaduLeabu-coding commented Oct 28, 2025

Uh oh!

RaduLeabu-coding commented Oct 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

RaduLeabu-coding commented Oct 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants