Conversation
readInt only looked at the stream state when the read had succeeded, so a failed read returned whatever the uninitialised buffer held instead of reporting the problem. The check now runs on the result of the read itself.
A Selafin mesh reads its frame and its values lazily, so a file truncated or rewritten by another program while MDAL holds it open fails in the middle of a read that happens under the C API, which has no exception handling of its own. The four lazy readers now catch the failure, log it and return 0.
Saving a Selafin mesh onto the file it was loaded from truncated that file while the driver was still reading its frame from it. The mesh frame is now collected before any output is opened, written to a temporary file, and that file put in place of the target only once it has been written in full.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various safety fixes when reading and writing selafin from/to disk
Fixes done by Claude (Flable or Opus) while working on other branches.