Skip to content

fix(quota): hydrate and persist account quota snapshots - #397

Closed
luvs01 wants to merge 10 commits into
Devfrom
codex/fix-quota-snapshot-hydration-and-persistence
Closed

fix(quota): hydrate and persist account quota snapshots#397
luvs01 wants to merge 10 commits into
Devfrom
codex/fix-quota-snapshot-hydration-and-persistence

Conversation

@luvs01

@luvs01 luvs01 commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The runtime declared disk-backed helpers for per-account quota snapshots but never wired them into production reads or successful probe updates, so evidence was lost across restarts and pre-dispatch ranking remained blind.
  • Persisting newly measured Anthropic/Kiro per-account quota to disk ensures restart-time ordering uses last-known headroom and avoids wasted rotation retries.
  • Add a small integration regression to prove disk→runtime hydration and that ordinary probes schedule a debounced snapshot write.

Description

  • Seed the in-memory per-account quota map from the persisted snapshot by calling hydrateAccountQuotaCache() from routing-facing reads and reconciliation points.
  • Schedule debounced disk writes by calling persistAccountQuotaCache() after successful Anthropic and Kiro provider-level probes and after successful per-account probes.
  • Add a test-only reset helper resetProviderAccountQuotaDiskStateForTests() and update persistence tests to assert that persisted rows hydrate the runtime cache and that production probes schedule writes.
  • Make clearAccountQuotaCache() avoid re-seeding from the file just cleared to prevent races with immediate file-backed writes.

Testing

  • ✅ Ran focused tests: node_modules/bun/bin/bun.exe test tests/provider-account-quota-persistence.test.ts tests/provider-account-quota.test.ts and observed the added persistence/hydration assertions pass (23 tests).
  • ✅ Typecheck succeeded with node_modules/bun/bin/bun.exe run typecheck.
  • ✅ Privacy scan succeeded with node_modules/bun/bin/bun.exe run privacy:scan.
  • ❌ Full suite attempted (node_modules/bun/bin/bun.exe run test) but encountered unrelated, pre-existing failures in other subsystems (lab automation and a few integration tests); these unrelated failures prevented a completed full-suite run in this environment.

Codex Task

lidge-jun and others added 10 commits August 25, 2026 10:36
release: promote dev into main for v2.32.1
# Conflicts:
#	package.json
[WRONG BRANCH] merge dev into main for the v2.33.0 release
Promotes the dev integration line onto main. The resulting tree is byte-identical
to origin/dev, including package.json at 2.34.0.

The package.json conflict is resolved to dev's side, NOT to main's stale 2.33.0.
Earlier promotions (lidge-jun#2553, lidge-jun#2507) kept the target's version so the release bump
would land on its own "release: vX.Y.Z" commit. That is no longer legal: this very
delta adds tests/release-version-line.test.ts, which fails when the in-tree version
sits behind the highest release tag. With v2.34.0-preview.20260827 now published,
2.33.0 orders behind it, so a promotion carrying the stale line turns CI red on
every shard that runs the suite.

The consequence for the release step is that scripts/release.ts skips the bump
(release.ts:568, currentVersion === version), so v2.34.0 gets tagged on this merge
commit rather than on a separate release commit. The workflow creates the tag itself
after publishing and validates expected-sha against the checked-out commit, so the
tag still names exactly the audited tree.
[WRONG BRANCH] promote dev onto main for v2.34.0
[WRONG BRANCH] promote dev onto main for v2.35.0
[WRONG BRANCH] promote dev onto main for v2.36.0
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: e2a6325d-ba70-41a6-821f-de2350b262a4


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T01:07:00.245163Z 6087fbe PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

✅ READY

  • all PR quality gates passed.

Hygiene

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title fix(quota): hydrate and persist account quota snapshots [WRONG BRANCH] fix(quota): hydrate and persist account quota snapshots Aug 31, 2026
@github-actions
github-actions Bot marked this pull request as draft August 31, 2026 01:17
@luvs01 luvs01 changed the title [WRONG BRANCH] fix(quota): hydrate and persist account quota snapshots fix(quota): hydrate and persist account quota snapshots Sep 3, 2026
@luvs01
luvs01 changed the base branch from main to dev September 3, 2026 06:22
@github-actions
github-actions Bot marked this pull request as ready for review September 3, 2026 06:31
@luvs01

luvs01 commented Sep 7, 2026

Copy link
Copy Markdown
Owner Author

상류 dev의 src/providers/quota.tshydrateAccountQuotaCache()/persistAccountQuotaCache()가 정의되어 읽기·쓰기 경로 양쪽에서 호출됩니다. 이 PR이 추가하려던 스냅샷 영속화가 상류 커밋 3e3df05aa(lidge-jun#2880)로 반영되어 가치 소멸.

@luvs01 luvs01 closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants