Bind Cursor retry replay to the admitted OAuth account on 429 failover - #446
Bind Cursor retry replay to the admitted OAuth account on 429 failover#446luvs01 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
Description
applyFailoverSnapshotto return the admittedOAuthAccessSnapshotornullinstead of a boolean so callers learn which snapshot was actually installed.bindRouteReasoningReplayScopereceives the sameaccountId/generationthat the retry will use.replayOAuthCredentialSnapshot,genericFailoverAccountId, and route provider fields are updated from the committed/admitted snapshot so routing metadata and bearer stay synchronized.tests/oauth/adapter-event-oauth-failover.test.tsto observe credential/continuation identity and assert the retry is scoped to the admitted manual account rather than the rejected proposal.Testing
bun test tests/oauth/adapter-event-oauth-failover.test.ts, which passed (12 tests, 0 failures).bun run typecheck, which completed without errors.bun run privacy:scan, which passed.bun run testwas executed; the modified focused tests passed inside that run, but the full parallel suite exited nonzero due to unrelated/timebox-sensitive failures (existing environment/timeouts), not regressions from this change.Codex Task