[WRONG BRANCH] security: remove account-identifying screenshots and sanitize live-verification notes - #468
Conversation
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
changed the title
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47c3114f77
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Verification ran against an isolated scratch instance on port 10399, started with | ||
| `bun run src/cli/index.ts start --port 10399` from this worktree. The scratch home was | ||
| deleted when verification finished. |
There was a problem hiding this comment.
Sanitizing this record and deleting the files only removes them from the new tree; the account-identifying images remain directly retrievable from parent bba63222 (for example, git show 8a28a7d^:devlog/_plan/260904_provider_quota_refresh/assets/030_accounts_refresh_button.png), which remains an ancestor of this commit and therefore preserves the disclosure for every clone. Rewrite the affected reachable history and coordinate removal of hosted PR/cache refs, rather than treating this tip-only deletion as completed remediation.
AGENTS.md reference: AGENTS.md:L122-L127
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Superseded by a focused cleanup of the same four files, with the historical verification outcomes preserved. No independent change remains in this proposal. |
1 participant
Motivation
auth.jsonstate and two committed GUI screenshots contained unredacted OAuth account email addresses, creating an information-disclosure risk.Description
devlog/_plan/260904_provider_quota_refresh/assets/(030_accounts_refresh_button.png,040_accounts_refresh_result.png).devlog/_plan/260904_provider_quota_refresh/031_live_verification_record.mdto remove references to the operator's local home, the copiedauth.jsonprovenance, and the pooled-account details, and to note only that an isolated scratch instance was used and deleted.devlog/_plan/260904_provider_quota_refresh/030_wp3_live_verification_and_pr.mdso the capture plan no longer points at the removed assets.Testing
bun run privacy:scanand observedPrivacy scan passed.git diff --checkandgit diff --statto verify the patch and found no whitespace or diff errors.rgfor the removed asset names and operational provenance strings and confirmed they no longer appear in the current tree.security: remove account-identifying screenshotsand verifiedgit status --short --branchshows a clean working tree.Codex Task