E2E tests for ONNX and RVC4 NNArchive metric consistency with LuxonisTrain#18
Draft
dtronmans wants to merge 2 commits into
Draft
E2E tests for ONNX and RVC4 NNArchive metric consistency with LuxonisTrain#18dtronmans wants to merge 2 commits into
dtronmans wants to merge 2 commits into
Conversation
dtronmans
marked this pull request as draft
July 16, 2026 10:23
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
For the semantic segmentation, instance segmentation, keypoint detection and object detection tasks, run an NNArchive to evaluate the metric scores and compare to baseline checkpoint metrics. Tests fail if the difference for any metric between NNArchive and checkpoint is > 2%.
Some notes:
pytest tests/test_rvc4_nnarchive_regression.py -q --device-ip <ip-or-mxid>or through the testbed:pytest tests/test_rvc4_nnarchive_regression.py -q --testbed-name <testbed-name>_get_dataset_identifier: this addition was maybe needed because my LuxonisML was installed on the latest version (0.9.0) and the identifier for the dataset name changed (will check this myself).RegressionCaseas a dataclass with only astrlooks redundant but this might be needed for the future when extra parameters get attached to each test case, like with the parse-export equivalence tests in LuxonisML.NormalizedTestDatais on Google Cloud buckets, and for each task contains:Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable
AI Usage
Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Submitted code was reviewed by a human: YES/NO
The author is taking the responsibility for the contribution: YES/NO