fix: drift-script crash on non-UTF-8 consoles, v1.7.1 - #6
Merged
Conversation
Discovered while doing a fourth documentation pass over the upstream three-axes-framework repo: a command-naming fix there (unrelated to this project) caused genuine drift, and running check_framework_drift.py to confirm it crashed with UnicodeEncodeError trying to print the diff. Windows consoles default stdout to the system codepage (cp1252), which can't encode characters like the down-arrow in SKILL.md's tier diagram -- so the script broke exactly at the one moment it had something real to show. Fixed by forcing UTF-8 output via sys.stdout.reconfigure() at the top of main(). Verified against the actual pending drift: the script now prints the diff correctly. That drift turned out to be cosmetic (command-name formatting, not a conceptual framework change) -- accepted as the new baseline via --update-snapshot rather than requiring a philosophy.md edit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discovered while doing a fourth documentation pass over the upstream three-axes-framework repo: a command-naming fix there caused genuine drift, and running
check_framework_drift.pyto confirm it crashed withUnicodeEncodeError-- Windows consoles default stdout to cp1252, which can't encode characters like "↓" in SKILL.md's tier diagram. Fixed viasys.stdout.reconfigure(encoding="utf-8").Verified against the actual pending drift: the script now prints the diff correctly. That drift was cosmetic (command-name formatting), so accepted as the new baseline via
--update-snapshotrather than requiring aphilosophy.mdedit.Test plan
python tests/test_check_progress_schema.py-- 7/7 pass (unaffected)plugin.jsonvalidated as well-formed JSON🤖 Generated with Claude Code