Skip to content

Stabilize AppServer lifecycle interrupt join test - #137

Merged
lynnswap merged 1 commit into
mainfrom
codex/fix-appserver-lifecycle-test-race
Aug 22, 2026
Merged

Stabilize AppServer lifecycle interrupt join test#137
lynnswap merged 1 commit into
mainfrom
codex/fix-appserver-lifecycle-test-race

Conversation

@lynnswap

@lynnswap lynnswap commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Purpose

Remove a scheduler-dependent terminal assertion that intermittently fails the AppServer lifecycle test and blocks unrelated pull requests.

Changes

  • Keep the event-session setup used by the lifecycle close test.
  • Keep the assertions proving close remains incomplete while the admitted interrupt is held and completes only after that interrupt finishes.
  • Remove the unrelated assertion that raced notification-stream failure against the successful interrupt terminal; dedicated tests continue to own router and session failure propagation.

Testing

  • Targeted test repeated 1,000 times
  • AppServer tests (206 tests)
  • swift test --build-system swiftbuild --no-parallel
  • scripts/check-compatibility.sh
  • ReviewMonitor xcodebuild test (15 tests)
  • Two independent exact-diff audits

Screenshots

Not applicable.

@lynnswap lynnswap changed the title test(app-server): stabilize lifecycle interrupt join Stabilize AppServer lifecycle interrupt join test Aug 22, 2026
@lynnswap

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 8ffd64f4ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap
lynnswap merged commit 003850e into main Aug 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant