Skip to content

Own prepared runtime generations - #139

Merged
lynnswap merged 1 commit into
mainfrom
codex/prepared-runtime-generation-v4-pr
Aug 22, 2026
Merged

Own prepared runtime generations#139
lynnswap merged 1 commit into
mainfrom
codex/prepared-runtime-generation-v4-pr

Conversation

@lynnswap

@lynnswap lynnswap commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Purpose

Prevent stale runtime preparation from publishing after stop, restart, or account transition while preserving the current MCP listener across same-account AppServer replacement.

Changes

  • Add Store-owned monotonic runtime generations and inert prepared runtime handles.
  • Capture retiring runtime and MCP resources in one state-owned acquisition context before asynchronous work begins.
  • Split MCP prepare and activate with exact-generation validation and deterministic stale cleanup.
  • Integrate SettingsService cutover begin, commit, cancel, and failure abort without losing deferred writes.
  • Carry typed teardown intent through runtime failure and explicit-stop supersession.
  • Close Live and Direct request admission before teardown and join auth notification and initial rate-limit work.
  • Preserve same-account MCP listener generation and URL while replacing AppServer state.

Testing

  • Store lifecycle tests (16 tests)
  • Host tests (48 tests)
  • swift test --build-system swiftbuild --no-parallel
  • Compatibility consumer, API, and MCP golden gates
  • ReviewMonitor xcodebuild test
  • Two exact-diff reviews, including Codex review with 0 findings

Screenshots

Not applicable.

Prepare runtime resources inertly and publish them only after generation and settings-cutover revalidation. Preserve exact teardown causes, MCP ownership, and recycle cleanup across cancellation and successor admission.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@lynnswap lynnswap changed the title refactor(runtime): own prepared runtime generations Own prepared runtime generations Aug 22, 2026
@lynnswap

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 3d4bb8d370

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap
lynnswap merged commit 9dfd36f into main Aug 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant