#44 Change the string split to manage multibyte. #48
Open
bhennesAdv wants to merge 1 commit intolyra:masterfrom
Open
#44 Change the string split to manage multibyte. #48bhennesAdv wants to merge 1 commit intolyra:masterfrom
bhennesAdv wants to merge 1 commit intolyra:masterfrom
Conversation
…appeared in PHP-7.4, the composer PHP minimum version must be 7.4 with mbstring extension. See the issue for the problem it resolves : lyra#47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
See the issue for the problem it resolves : #47
As the function appeared in PHP-7.4, the composer PHP minimum version must be 7.4 with mbstring extension.
I'll let you decide if this is worth or if you want to do your own implementation of mb_str_split to keep compatibility with older versions of PHP.
Best Regards,
Baptiste