Stabilize the JUnit 4 API#8857
Merged
Merged
Conversation
swankjesse
commented
Jun 14, 2025
| } | ||
| } | ||
|
|
||
| @Throws(IOException::class) |
Collaborator
Author
There was a problem hiding this comment.
Throwing IOException here just isn’t useful!
swankjesse
commented
Jun 14, 2025
| for (queue in taskRunner.activeQueues()) { | ||
| if (!queue.idleLatch().await(5, TimeUnit.SECONDS)) { | ||
| throw IOException("Gave up waiting for queue to shut down") | ||
| throw AssertionError("Gave up waiting for queue to shut down") |
Collaborator
Author
There was a problem hiding this comment.
If this occurs in practice . . . the system is unhealthy. I think crashing hard like this is okay.
yschimke
approved these changes
Jun 14, 2025
swankjesse
force-pushed
the
jwilson.0614.junit4
branch
from
June 16, 2025 15:07
7a1dae9 to
01decd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.