Fix a liveness bug in MockWebServer#8858
Merged
Merged
Conversation
It was possible to configure delays that would be honored after MockWebServer was shut down. With this fix any delay will be abandoned once the server is closed.
JakeWharton
approved these changes
Jun 15, 2025
…os.kt Co-authored-by: Jake Wharton <jw@squareup.com>
yschimke
approved these changes
Jun 16, 2025
| if (policy.throttlePeriodNanos > 0L) { | ||
| result = | ||
| ThrottledSink( | ||
| socket = socket, |
Collaborator
There was a problem hiding this comment.
Not for this review, but should we be aiming for all operations like this to be on okio socket?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was possible to configure delays that would be honored after MockWebServer was shut down. With this fix any delay will be abandoned once the server is closed.