Skip to content

Decompose the request line into individual properties#8860

Merged
squarejesse merged 4 commits into
masterfrom
jwilson.0616.request_line
Jun 17, 2025
Merged

Decompose the request line into individual properties#8860
squarejesse merged 4 commits into
masterfrom
jwilson.0616.request_line

Conversation

@squarejesse

Copy link
Copy Markdown
Contributor

Replace the 'path' property with the URL's encodedPath property.

Rename the 'requestUrl' property to 'url'.

Replace the 'path' property with the URL's encodedPath
property.

Rename the 'requestUrl' property to 'url'.
@squarejesse
squarejesse requested review from oldergod and yschimke June 16, 2025 16:53
Comment thread mockwebserver/src/main/kotlin/mockwebserver3/RecordedRequest.kt

@oldergod oldergod left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the result

Comment on lines +86 to +88
if (parts.size != 3) {
throw ProtocolException("unexpected request line: $requestLine")
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@squarejesse
squarejesse merged commit dfd1dff into master Jun 17, 2025
22 checks passed
@squarejesse
squarejesse deleted the jwilson.0616.request_line branch June 17, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants