Change some MockWebServer ergonomics#8861
Merged
Merged
Conversation
Now calling MockWebServer.port and similar functions will not implicity start the server. It is instead necessary to explicitly call the start() function. The problem with the old behavior was that reading the port field could fail with an IOException, which is weird behavior for reading a property.
swankjesse
commented
Jun 17, 2025
| } | ||
|
|
||
| @JvmName("-deprecated_port") | ||
| @Deprecated( |
Collaborator
Author
There was a problem hiding this comment.
UN-deprecating stuff from the old MockWebServer. This whole package is obsolete and these deprecation warnings aren’t benefiting anyone.
| public final fun setProtocolNegotiationEnabled (Z)V | ||
| public final fun setProtocols (Ljava/util/List;)V | ||
| public final fun setServerSocketFactory (Ljavax/net/ServerSocketFactory;)V | ||
| public final fun setStarted (Z)V |
Collaborator
Author
There was a problem hiding this comment.
This was bananas
|
|
||
| this._inetSocketAddress = inetSocketAddress | ||
| val alreadyStartedAddress = socketAddress_ | ||
| if (alreadyStartedAddress != null) { |
Collaborator
Author
There was a problem hiding this comment.
Start used to silently ignore calls after it was started, even if the target address had changed
Collaborator
|
LGTM but GitHub erroring on approve |
swankjesse
force-pushed
the
jwilson.0617.mockwebserver_apis
branch
from
June 17, 2025 23:37
5668711 to
db614ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now calling MockWebServer.port and similar functions will not implicity start the server. It is instead necessary to explicitly call the start() function.
The problem with the old behavior was that reading the port field could fail with an IOException, which is weird behavior for reading a property.