Switch to @StartStop for JUnit 5 tests#8863
Merged
Merged
Conversation
This is a new take on our JUnit 5 extension. Rather than creating and managing the MockWebServer instance in the extension, we let the user create it and all the extension does is manage the lifecycle. Note that this annotation doesn't require any external configuration - it doesn't need a system-property to opt-into 'automatic' extensions, and it doesn't require a class-level extension either.
swankjesse
force-pushed
the
jwilson.0617_start_stop_start
branch
from
June 18, 2025 02:36
9eb6899 to
a96c03c
Compare
yschimke
reviewed
Jun 18, 2025
| var platform = PlatformRule() | ||
|
|
||
| private lateinit var server: MockWebServer | ||
| private val server = MockWebServer() |
Collaborator
There was a problem hiding this comment.
This pattern now feels unsafe, since server.stop() must be called.
But existing problem.
yschimke
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.