Add a connectionIndex field to RecordedRequest#8866
Merged
Conversation
Also rename 'sequenceNumber' to 'exchangeIndex'. This may be useful to test features like connection reuse.
swankjesse
commented
Jun 18, 2025
| chunkSizes = chunkSizes, | ||
| bodySize = bodySize, | ||
| body = Buffer().write(body ?: ByteString.EMPTY), | ||
| sequenceNumber = sequenceNumber, |
Collaborator
Author
There was a problem hiding this comment.
(Still sequenceNumber in the old API)
| @Target(AnnotationTarget.FIELD) | ||
| @Retention(AnnotationRetention.RUNTIME) | ||
| @ExtendWith(StartStopExtension::class) | ||
| @ExperimentalOkHttpApi |
Collaborator
Author
There was a problem hiding this comment.
Sneaking this in
|
|
||
| if (sequenceNumber == 0) { | ||
| if (nextExchangeIndex == 0) { | ||
| logger.warning( |
Collaborator
Author
There was a problem hiding this comment.
Now it’s possible to derive this information from the public API . . . the connection index of the next call will have skipped one!
yschimke
approved these changes
Jun 19, 2025
| sslSocketFactory != null -> { | ||
| if (socketPolicy === FailHandshake) { | ||
| dispatchBookkeepingRequest(sequenceNumber, raw) | ||
| dispatchBookkeepingRequest(connectionIndex, nextExchangeIndex++, raw) |
Collaborator
There was a problem hiding this comment.
Nice logical improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also rename 'sequenceNumber' to 'exchangeIndex'.
This may be useful to test features like connection reuse.