emulator 37 testing#9515
Merged
yschimke merged 2 commits intoJun 27, 2026
Merged
Conversation
Refactor the android CI job to drive the emulator matrix off an explicit target/arch include list and add an experimental, non-blocking API 37 (16 KB page-size) entry. Warm the Gradle cache by assembling the instrumentation APK instead of running the Robolectric unit tests, match the snapshot boot options on the run step so cached snapshots restore, and bump emulator memory/GPU/feature flags for headless runs. Extracted from the testing_ech branch so the emulator setup can land ahead of the ECH work.
Three environmental differences surface on the API 37 emulator image and make connectedCheck fail there: - The GmsCore Conscrypt provider negotiates TLS 1.3 (not 1.2) from API 37 onward, so assert the version conditionally. - The dual-stack loopback tries the unbound address first, emitting a ConnectStart/ConnectFailed pair before the successful connect; filter those pairs out so the event-sequence assertion is stable across single- and dual-stack environments. - Peer verification failures can arrive wrapped (as a cause or suppressed exception) rather than thrown directly; accept any of those shapes. These are independent of the Android 17 platform/ECH work, so they can land with the emulator CI setup ahead of it.
Collaborator
Author
|
@swankjesse requesting post review. Want API 37 landed for two separate prs. |
swankjesse
reviewed
Jul 10, 2026
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| # The pre-release API 37 emulator image is still maturing, so let the entry marked | ||
| # experimental fail without blocking the build until the image is stable on CI. |
| -no-boot-anim | ||
| -camera-back none | ||
| -memory 2048 | ||
| -memory ${{ matrix.memory || '2048' }} |
Collaborator
There was a problem hiding this comment.
doing matrix + defaults is nice
| fail<Any>("") | ||
| } catch (_: SSLPeerUnverifiedException) { | ||
| } catch (e: Exception) { | ||
| // The API 37 emulator can surface the verification failure wrapped (as a cause or a |
Collaborator
There was a problem hiding this comment.
aww, that’s a regression. Does that impact RetryAndFollowUpInterceptor ?
| } | ||
|
|
||
| /** | ||
| * Returns these events with failed connection attempts removed. On a dual-stack loopback the |
Collaborator
There was a problem hiding this comment.
I wonder how many other users will get impacted by this?!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.