Open
Conversation
Apply thread-safety fixes from tidwall/SwiftWebSocket#141 to embedded copy of SwiftWebSocket
For download test, prefer measurements of bytes confirmed received by client For upload test, prefer measurements of bytes confirmed recevied by server See also: m-lab/ndt7-client-go#75
Instead of fixed time interval delay when buffering is encountered, adjust delay based on currently calculated bitrate to estimate time to flush buffer before resuming upload
Scaling upload frame payload size is preferred to sending multiple (100) copies of same relatively small frame for upload tests
Avoid unnecessary JSON parsing of '{}'
As recommended in NDT7 protocol increase size of upload message payload as test progresses, doubling up to maxMessageSize when the current binary message size is <= than 1/scalingFactor of the bytes sent so far
Contributor
|
@olgagalchenko Are you able to take a look at this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily motivated by finding poor results during upload speed tests
SwiftWebSocket: thread-safety fixes
Use one source for measurements in each direction (See also: m-lab/ndt7-client-go#75)
Remove hardcoded delay when output is buffered
Remove crude repeats of same WebSocket frame
Minor optimization to local measurement reporting
Implement upload message scaling
This change is