Skip to content

added counter-query parameter - #33

Open
lcorsini wants to merge 37 commits into
m-lab:mainfrom
lcorsini:master
Open

added counter-query parameter#33
lcorsini wants to merge 37 commits into
m-lab:mainfrom
lcorsini:master

Conversation

@lcorsini

@lcorsini lcorsini commented Mar 11, 2021

Copy link
Copy Markdown

This is a quick change to add support for counter metrics, I don't know if this is something other needs but was a requirement in our projects
after some months of testing I tought it would be good to make a pr :D


This change is Reviewable

@coveralls

coveralls commented Mar 11, 2021

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 142

  • 31 of 79 (39.24%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-18.3%) to 81.679%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/setup/setup.go 0 8 0.0%
internal/config/config.go 31 71 43.66%
Totals Coverage Status
Change from base Build 139: -18.3%
Covered Lines: 214
Relevant Lines: 262

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants