Repository navigation
T8142 DisplayPort: J813 fixes (crossbar config, USB without the DP banks, recovery fixture) - #2
Merged
m0d16l14n1 merged 3 commits intoNov 16, 2026
Conversation
… endpoint "drm/apple: T8142 dcpext: take the audio interface on dcpav-interface-ep" makes afk_compact_capable() compare the endpoint with dcp_av_audio_endpoint(). The retained recovery control actual-queue-quiesce compiles that function without the helper, so it no longer built and service-rebind failed. When afk_compact_capable() uses it, give the fixture hw.av_audio_endpoint and the helper from dcp-internal.h, as it already does for the M4 check. Signed-off-by: Thomas Glanzmann <thomas@glanzmann.de>
… DisplayPort calibration
On T8142 the mode switch refuses every mode with DP AUX while the boot
loader's LIOA and common configuration banks are missing ("DisplayPort
bank calibration missing; DP disabled"). A partner in DP Alt Mode then
loses its USB as well: on a J813 with a dock in pin assignment D, under
a loader without the bank export, the PHY init fails with -EOPNOTSUPP
and the port's dwc3 never probes, where the kernel before the T8142
DisplayPort sequence ran the dock's hub at 10 Gb/s.
Map the DP modes to the USB the partner keeps, as T8132 does: USB2 next
to four DP lanes (pin assignments C and E), USB3 next to two (D).
atc-usb3-tests covers the mapping with and without the banks.
Signed-off-by: Thomas Glanzmann <thomas@glanzmann.de>
Every external display route of the T8142 Airs goes through the display
crossbars (apple,t8142-display-crossbar). Without their driver both
dcpext processors wait for the crossbars until the deferred probe
timeout and end as unusable pipes ("external display processor unusable
(probe failed: -110)"), so the j813.config kernel shows no external
display although the boot loader hands both processors over.
Signed-off-by: Thomas Glanzmann <thomas@glanzmann.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes on top of
j815/t8142-dp-altmode-wip(aurora-silicon#1806, head e4bdeb8), found while running it on a J813 under the macOS 27.2 stub, with Linux at EL2.J813 result
The external display works on a J813 (Mac17,3), macOS 27.2 (26B123) stub, Linux at EL2:
608e17b8,91e2ffbeandb97ef3a8from your aura branch, enrolled./chosen/aurora,dcpext{0,1}-handoffreadokay, and both processors probe.card1-DP-2at 2560x1440@59.95, next toeDP-1, under sway. The dock's USB keeps running.What this adds
afk_compact_capable()calldcp_av_audio_endpoint().actual-queue-quiescecompiles that function without the helper, so on e4bdeb8 it fails to build andapple-dcp'sservice-rebindfails.hw.av_audio_endpointand the helper, as it already does for the M4 check.phy init failed --> -95, and40a280000.usbnever probed. The kernel before the T8142 DisplayPort sequence ran that dock's hub at 10000M.j813.confighas noMUX_APPLE_DPXBAR.apple,t8142-display-crossbarnodes never bind. Both dcpext then wait until the deferred probe timeout and end "external display processor unusable (probe failed: -110)", although the loader handed them over.Testing
tools/asahi/run-host-tests.py: 323/323 on this branch (on e4bdeb8apple-dcpfails).atc-usb3-testshas new cases for the T8142 mapping, with and without the banks. On the PHY code without fix 2, they fail.j813.configresolves toCONFIG_MUX_APPLE_DPXBAR=y. The Image and the J813 DTB build (LLVM 22).atc.cbuilds with W=1 and no warnings. checkpatch--strictis clean.cc @Acelogic @DjDeveloperr @RyanTheTide @LiamRay10