fix(windows): normalize file-root ACL inheritance - #54
Merged
Merged
Conversation
Co-authored-by: codex <codex@openai.com>
Co-authored-by: codex <codex@openai.com>
Co-authored-by: codex <codex@openai.com>
Co-authored-by: codex <codex@openai.com>
Co-authored-by: codex <codex@openai.com>
Co-authored-by: codex <codex@openai.com>
Co-authored-by: codex <codex@openai.com>
Co-authored-by: codex <codex@openai.com>
Co-authored-by: codex <codex@openai.com>
Co-authored-by: codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Granting read access to an existing individual file could fail before Windows sandbox launch with
FilesystemEnforcement::AceMismatch. Explicit file roots retained directory inheritance flags, which Windows removes from file ACEs.ACL preparation now determines file/directory kind through the same validated, non-reparse handle used for descriptor inspection and mutation. File ACEs have exact scope; directory ACEs retain inheritance. Explicit roots and enumerated descendants share this normalization. Exact descriptor verification, access masks, journaling, and restoration remain enforced. A file grant does not modify its parent or siblings.
The native regression verifies repeated direct reads, filenames with spaces, file metadata, denied writes, denied sibling reads and directory listing, and exact DACL restoration on uninstall. It also runs the identical
cmd.exe /c type <path>command under two policies: a file-only grant denies the command's directory lookup, while an explicit containing-directory read grant permits it. Direct file reading succeeds without that broader grant.Validation on
d815ded: CI run 35821613254 passed. All 14 Windows backend integration tests passed in each of the three feature modes. Common checks and Java/Python binding jobs passed on Linux, macOS, and Windows; both Linux packaged-consumer QEMU jobs and all six CLI cross-builds passed. Standalone Linux/macOS native backend jobs were not selected for this Windows-only change.The final source change is confined to Windows file-kind detection and ACL normalization, with native regression coverage and the Windows specification updated. No public API, dependency, version, release workflow, or security permission expansion is included. This is a patch-level fix.