[pull] main from rmyndharis:main#1
Merged
Merged
Conversation
… modal (#634) * fix(dashboard): make dark theme cover all surfaces + widen plugin install modal Several dashboard components used hardcoded colors that bypassed the CSS-variable theme system, so a number of surfaces stayed light when the dark theme was active — most visibly the Infrastructure "Database Migrations" card, plus status/severity badges, toasts, danger-hover states, and toggle tracks. Replace the hardcoded literals with the existing theme tokens (backgrounds, text, borders) and translucent semantic fills so every surface follows the active theme in both light and dark. Add an `--info` token for the blue badges (permission, SQLite, info logs, qr-ready) that previously had no theme-aware color, and stop the light-preference media query from force-whitening the root element when the user explicitly selects the dark theme on a light-OS device. Also widen the "Install a plugin" modal on desktop (480px to 680px) for the catalog list, keeping the shared responsive rules (full-width bottom sheet on small screens). * fix(dashboard): move install-modal width to a global stylesheet + changelog The page-root scope test requires every rule in a page CSS file to be scoped under its page class; the .modal.install-modal width override was left unscoped in Plugins.css. Move it into index.css alongside the base .modal styles (a global stylesheet, exempt from the scope rule) — the natural home for modal styling anyway. Catalog the dark-theme and modal changes under [Unreleased].
#624) Replaces the native `<select>` on Sessions (status filter), Logs (severity filter), and Login (language picker) with a reusable design-system CustomSelect: dark/light theming, keyboard navigation (arrows, Home/End, type-ahead, Escape), focus returned to the trigger on close (WCAG 2.4.3), and responsive behavior. Thanks @haseeblodhi1899.
…um + slots (#635) A terminal engine error and a reconnect whose re-initialization throws both left the dead or half-built engine in the session registry, holding a concurrency slot and making a subsequent start reject the session as 'already started'. Both paths now evict the engine and force-kill its Chromium process. delete() also force-kills (SIGKILL) rather than a graceful destroy() that could hang on a wedged browser and orphan the process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )