[pull] main from rmyndharis:main#3
Merged
Merged
Conversation
…652) The bundled compose files shipped pids_limit: 512 since the #243 hardening pass, chosen as a fork-bomb guard without accounting for Chromium's multi-process model. whatsapp-web.js runs a full Chromium instance per session (browser + renderer + GPU + zygote + utilities) and WhatsApp Web is itself process-heavy (service workers, iframes), so ~4 concurrent sessions already approach 512 — the next session's Chromium gets killed mid-spawn when a fork() returns EAGAIN, surfacing in the API as `Failed to launch the browser process: Code: null`. Parameterize the ceiling via OPENWA_PIDS_LIMIT (default 2048, fits ~8-10 sessions with startup-spike headroom) and document it. The limit is a cgroup pids.max ceiling, not an allocation, so raising it is a no-op for light containers — Baileys (no Chromium, single-process) uses only a handful of PIDs regardless. The fork-bomb guard stays finite; -1 (unlimited) is explicitly discouraged. Also adds a troubleshooting entry distinguishing the three causes of `Code: null` (PID exhaustion vs OOM-kill vs the XDG/crashpad crash already fixed in #254), since the dbus/crashpad noise in the log is non-fatal and the real cause isn't visible without docker stats / dmesg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )