fix: make $queryRawTyped conditional on typedSql preview feature#21
Merged
Conversation
…eature Fixes issue #20 where $queryRawTyped was always generated even when the typedSql preview feature was not enabled, causing TypeScript errors. The generator now detects whether any Prisma generator has the typedSql preview feature enabled and only generates $queryRawTyped and imports the runtime module when it's available. Added tests to verify: - $queryRawTyped is generated when typedSql is enabled - $queryRawTyped is not generated when typedSql is not enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #20 where
$queryRawTypedwas always generated, causing TypeScript errors when thetypedSqlpreview feature wasn't enabled. The generator now detects whethertypedSqlis available and only generates the method when it's present.Changes
typedSqlpreview feature across all Prisma generators$queryRawTypedonly when enabled@prisma/client/runtime/clientonly when neededTesting
All existing tests pass, plus new tests verify the feature works correctly in both configurations.