Repository navigation
fix(bench): count matches correctly and keep diagnostics value-safe - #94
Merged
Merged
Conversation
mazzasaverio
marked this pull request as ready for review
October 2, 2026 06:33
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # HANDOVER.md # tests/integration/test_release_verifier.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local benchmark updated matched truth outside the matching loop, producing incorrect one-to-one accounting and UnboundLocalError for empty/disjoint inputs. Correct the loop and verify exact TP/FP/FN, precision, recall and F1. Explanation logs now emit row/type/offsets without source values; optional ML imports are lazy and importing the module no longer configures the root logger.
Validation: six new cases failed before the fix; 13 focused tests passed afterwards. Full CI passed 531 tests per matrix job with 95.15% to 95.22% coverage, plus quality, docs, performance, property, packaging and installed-wheel checks: https://github.com/ma2za/pseudonymize/actions/runs/36973067973 . This repairs the local harness and does not revise the separate published quality baseline.
Current review status
Review priority: 3 of 9; PR #100 is the packaging prerequisite. Updated against main
17e8fccwhile preserving development version 1.37.0 and the hosted-service changes. Includes the shared service-extra audit correction from #100. No PR has been merged.Current branch validation: 24 focused tests passed; Ruff formatting/lint, mypy, wheel/sdist builds and release verification passed. Fresh CI on the current head completed with 18 successful checks, one skipped check, and no failures.