fix(quality): reject incomplete release evidence and approvals - #95
Open
mazzasaverio wants to merge 1 commit into
Open
mazzasaverio wants to merge 1 commit into
mazzasaverio wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quality gate returned SHIP with absent external evaluation, a missing critical entity or infinite external F1. Reject incomplete/invalid evidence, compare critical annotation support and report which entities actually have observations. The release verifier now requires all five criteria to pass explicitly and rejects legacy skipped external evaluations. Count-based F1 avoids division by zero for zero-TP entities.
Validation: three tests reproduced false approval; 40 focused tests passed after correction. Full CI passed 545 tests per matrix job with 95.00% to 95.06% coverage, plus quality, docs, performance, property, packaging and installed-wheel checks: https://github.com/ma2za/pseudonymize/actions/runs/36973630305 . Detector behavior and quality tolerances are unchanged. Reconciling the roadmap's stricter exact-boundary improvement protocol remains separate work, explicitly documented here.