Repository navigation
fix(api): treat client request-aborts as 499, not a logged 500 - #141
Merged
Merged
Conversation
A cancelled HTTP request (the client disconnects, or React Query aborts an in-flight query on unmount/refetch) makes ASP.NET's RequestAborted token fire and the in-flight EF query throw OperationCanceledException. It was falling into the catch-all — logged as "Unhandled exception" and answered with a 500 to a socket that's already gone. Catch it explicitly (guarded on RequestAborted) and return 499 without the error log. Expected behaviour, not an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cancelled HTTP request (client disconnects / React Query aborts an in-flight query) makes ASP.NET's
RequestAbortedtoken fire and the EF query throwOperationCanceledException— which fell into the catch-all, logged as 'Unhandled exception' + answered 500 to a dead socket. Catch it explicitly (guarded onRequestAborted.IsCancellationRequested) → return 499, no error log. Expected behaviour, not a bug.