Skip to content

⚡ Optimize regex performance by pre-compiling patterns #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maattyi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize regex performance by pre-compiling patterns #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/domain_fronter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@

from ws import ws_encode, ws_decode

# Pre-compiled regex patterns for performance
RE_CONTENT_RANGE = re.compile(r"/(\d+)")
RE_JSON_EXTRACT = re.compile(r"\{.*\}", re.DOTALL)
RE_STATUS_CODE = re.compile(r"\d{3}")
RE_COOKIE_SPLIT = re.compile(r",\s*(?=[A-Za-z0-9!#$%&'*+\-.^_`|~]+=)")

log = logging.getLogger("Fronter")


Expand Down Expand Up @@ -590,7 +596,7 @@ async def relay_parallel(self, method: str, url: str,

# Parse total size from Content-Range: "bytes 0-262143/1048576"
content_range = resp_hdrs.get("content-range", "")
m = re.search(r"/(\d+)", content_range)
m = RE_CONTENT_RANGE.search(content_range)
if not m:
# Can't parse — downgrade to 200 so the client (which sent a
# plain GET) doesn't get confused by 206 + Content-Range.
Expand Down Expand Up @@ -1012,7 +1018,7 @@ def _parse_batch_body(self, resp_body: bytes,
try:
data = json.loads(text)
except json.JSONDecodeError:
m = re.search(r'\{.*\}', text, re.DOTALL)
m = RE_JSON_EXTRACT.search(text)
data = json.loads(m.group()) if m else None
if not data:
raise RuntimeError(f"Bad batch response: {text[:200]}")
Expand Down Expand Up @@ -1049,7 +1055,7 @@ async def _read_http_response(self, reader: asyncio.StreamReader):
lines = header_section.split(b"\r\n")

status_line = lines[0].decode(errors="replace")
m = re.search(r"\d{3}", status_line)
m = RE_STATUS_CODE.search(status_line)
status = int(m.group()) if m else 0

headers = {}
Expand Down Expand Up @@ -1139,7 +1145,7 @@ def _parse_relay_response(self, body: bytes) -> bytes:
try:
data = json.loads(text)
except json.JSONDecodeError:
m = re.search(r'\{.*\}', text, re.DOTALL)
m = RE_JSON_EXTRACT.search(text)
if m:
try:
data = json.loads(m.group())
Expand Down Expand Up @@ -1201,7 +1207,7 @@ def _split_set_cookie(blob: str) -> list[str]:
return []
# Split on ", " but only when the following text looks like the start
# of a new cookie (a token followed by '=').
parts = re.split(r",\s*(?=[A-Za-z0-9!#$%&'*+\-.^_`|~]+=)", blob)
parts = RE_COOKIE_SPLIT.split(blob)
return [p.strip() for p in parts if p.strip()]

def _split_raw_response(self, raw: bytes):
Expand All @@ -1210,7 +1216,7 @@ def _split_raw_response(self, raw: bytes):
return 0, {}, raw
header_section, body = raw.split(b"\r\n\r\n", 1)
lines = header_section.split(b"\r\n")
m = re.search(r"\d{3}", lines[0].decode(errors="replace"))
m = RE_STATUS_CODE.search(lines[0].decode(errors="replace"))
status = int(m.group()) if m else 0
headers = {}
for line in lines[1:]:
Expand Down