Skip to content

🧪 [testing improvement] Add tests for core/multi_id.py - #7

Open
maattyi wants to merge 1 commit into
mainfrom
improve-multi-id-tests-3536165454303054951
Open

🧪 [testing improvement] Add tests for core/multi_id.py#7
maattyi wants to merge 1 commit into
mainfrom
improve-multi-id-tests-3536165454303054951

Conversation

@maattyi

@maattyi maattyi commented May 1, 2026

Copy link
Copy Markdown
Owner

This PR adds a comprehensive suite of unit tests for core/multi_id.py, addressing a missing test gap in the core routing logic.

🎯 What:

Added tests/test_multi_id.py with 14 test cases covering _Endpoint and MultiIdDispatcher classes.

📊 Coverage:

  • Endpoint Scoring: Verified all penalty calculations (latency, failures, cooldown, uses).
  • Dispatch Logic: Tested round-robin selection and preference for healthy endpoints.
  • Fault Tolerance: Confirmed parking behavior after reaching failure thresholds and recovery via emergency probing.
  • Reporting: Validated health() and snapshot() outputs.

✨ Result:

Increased reliability of the core routing logic by providing a deterministic test suite that prevents regressions in endpoint selection and health management.


PR created automatically by Jules for task 3536165454303054951 started by @maattyi

Implemented a new test suite for the health-based multi deployment-id router.
Scenarios covered:
- _Endpoint scoring logic (success rate, latency, failure, cooldown, and fairness penalties)
- MultiIdDispatcher selection logic (round-robin among eligible endpoints)
- Failure threshold and automatic endpoint parking
- Emergency probing when all endpoints are parked
- Health status and state snapshot reporting
- Moving average calculation for endpoint latency

Used unittest.mock to ensure deterministic testing of time-based logic.

Co-authored-by: maattyi <228237318+maattyi@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant