Repository navigation
test: the consumer check expects Bragg single precision on every detector size - #69
Merged
Merged
Conversation
…ctor size Since #61 the Float32 Bragg path builds FloatFFT2D(anyRows:columns:), so .single runs on every positive detector size and supportsSinglePrecision is true for all of them. The consumer check still expected a 40 x 56 .single run to throw invalidOption, so it failed 1 of 152 on main and on the Release PR. The check now runs .single and .double on a 22 x 21 detector (a size vDSP DFT cannot take, FloatFFT2D.supports is false) with one planted disk: both find one peak near it and agree within 1e-3 px. supportsSinglePrecision also covers 22 x 21 (true) and a negative column count (false), next to the existing zero-row case. No kit source or number changes. consumer-check: 152 of 152 pass; the fast gate is green. Done: the consumer check matches the #61 behaviour. Next: the Release PR CI goes green after this merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul · project thread
The Release PR #42 fails "Consumer checks and iOS build (after merge)" on 1 of 152 consumer checks:
BraggPrecision.single refuses an unsupported size. main fails the same check, and only that one.Cause. #61 made Bragg
.singlerun on every detector size (FloatFFT2D(anyRows:columns:), Bluestein where vDSP DFT cannot go). The consumer check still expected a 40 x 56.singlerun to throwinvalidOption.Change (tools/consumer-check only):
BraggPrecision.single accepts a non-vDSP size (22 x 21): one planted disk on a 22 x 21 detector (FloatFFT2D.supportsis false there)..singleand.doubleeach find one peak near the disk, and they agree within 1e-3 px. Measured gap: about 4e-8 px.BraggDetector.supportsSinglePrecisionnow also checks 22 x 21 (true) and a negative column count (false), next to the existing zero-row refusal.No kit source changes. No numbers move.
Tests
tools/consumer-check/run.shon origin/main (620646f): 152 checks, 1 failure (this one).swift test -c release --parallel --skip CuboKitParityTests: green.🤖 Generated with Claude Code