Repository navigation
docs: open-items says PatternCentre.find refuses a blocked beam - #66
Merged
Merged
Conversation
The blocked-beam item still said PatternCentre.find returns a Bragg spot or the stop rim. Since #55 it refuses them by checking the region against the Friedel centre. The item now names FriedelCentre (#53) and the refusal (#55), and keeps only what is left: the two-beam case the rule may refuse, and upsample factors above 1. Done: the open-items line matches main. Next: the parity.md rows for the ring fit, get_origin_friedel and the PatternCentre refusal, once fewer open branches touch that file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul · project thread
Follow-up to #53, #55 and #64.
The blocked-beam item in
docs/open-items.md(added by #64) still saidPatternCentre.findreturns a Bragg spot or the stop rim. Since #55 it refuses them: the brightest region must lie within half its radius (at least 2 px) of the Friedel centre. The item now says:FriedelCentre.findfinds a blocked-beam centre (feat: FriedelCentre, the centre of a pattern with a blocked beam #53);PatternCentre.findrefuses a blocked beam (fix: PatternCentre.find refuses a blocked beam instead of returning a Bragg spot or the stop rim #55,theBeamFinderRefusesABlockedBeam);Not in this PR: the
docs/parity.mdrows for the ring fit (#51, #52),get_origin_friedel(#53) and the PatternCentre refusal (#55). Two open branches already touch that file.Docs only; no code changed.
🤖 Generated with Claude Code