Repository navigation
chore: libhdf5 xcframework zips rebuilt without AppleDouble entries, resolved as -r2 assets - #55
Merged
Merged
Conversation
…resolved as -r2 assets
Package.swift now resolves FormatoLib{HDF5,SZ,AEC}-r2.xcframework.zip on the 0.4.0
release, with the checksums of zips rebuilt by tools/xcframework/build.sh (ditto
--norsrc --noextattr). The old assets stay on the release under their own names, so
every tag up to 0.11.0 still resolves with the checksums it pins. build.sh documents
the rebuild-suffix upload instead of gh release create.
Each zip lists no ._ entries (zipinfo), and each framework unzipped from it passes
codesign --verify --deep --strict. Checksums match swift package compute-checksum.
Done: rebuilt zips and Package.swift pointing at them. Next: the owner uploads the three
-r2 zips to the 0.4.0 release before this merges, then xcframework-url runs on main.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul · project thread
Part of #32
Do not merge before the upload below. Until the three
-r2zips are on the 0.4.0 release, a consumer resolving this commit by URL gets a 404.What changes
tools/xcframework/build.sh(which since chore: libhdf5 xcframework zips without AppleDouble entries, checked with codesign --strict #41 zips withditto --norsrc --noextattrand checks the result).Package.swiftresolves them asFormatoLibHDF5-r2.xcframework.zip,FormatoLibSZ-r2.xcframework.zipandFormatoLibAEC-r2.xcframework.zipon the existing0.4.0release, with the new checksums. A new suffixxcframeworkRebuild = "-r2"builds the asset name.tools/xcframework/build.sh: the header now says how to upload a rebuild beside the old assets, with a new suffix, instead of creating a release.Checks on the rebuilt zips
zipinfo -1: 14 entries per zip, no._*or__MACOSXentries (the 0.4.0 zips have 13._*entries each).codesign --verify --deep --stricton each.framework: "valid on disk" and "satisfies its Designated Requirement" for all three.swift package compute-checksummatchesshasum -a 256and the values inPackage.swift.swift package dump-packageresolves the three-r2URLs.FORMATO_LOCAL_XCFRAMEWORKS), so CI on this PR checks the manifest and the tests, not the URLs. Thexcframework-urljob checks the URLs once this is onmain.What Paul uploads
The zips are in
~/GitHub/.worktrees/FormatoKit-32-release/(copies ofdist/xcframeworks/*.zipunder the release names).FormatoLibHDF5-r2.xcframework.zipc16fd49b1935fd3c1be47bc391417894ecd0e1122dfda999f91129060b41925e("FormatoLibHDF5", "8b6b74bc…d236")FormatoLibSZ-r2.xcframework.zipc41dd18fedd12bcbc9dbbb79cc331c7244ac9d3ec3e4f712b20457d3063fdb52("FormatoLibSZ", "52388745…0a28d")FormatoLibAEC-r2.xcframework.zipfd8fed678701cc671ba4a7880f577485b0283634113e39ca05f949cbcee759ad("FormatoLibAEC", "bef7dd23…d28518")Steps:
0.4.0release, next to the old ones (do not delete or overwrite the old assets):gh release upload 0.4.0 ~/GitHub/.worktrees/FormatoKit-32-release/FormatoLib{HDF5,SZ,AEC}-r2.xcframework.zip -R mac4DSTEM/FormatoKitgh api repos/mac4DSTEM/FormatoKit/releases/tags/0.4.0 --jq ".assets[].name"should list six zips.xcframework-urljob onmainthen resolves the new URLs with these checksums.What remains for #32
xcframework-urlrun onmain.codesign --verify --deep --stricton the archive. That needs a signed archive, so it is left to Paul.🤖 Generated with Claude Code