Repository navigation
ci: release-please dates CITATION.cff itself; drop the sed step - #60
Merged
Merged
Conversation
release-please has a date updater after all: the generic updater (release-please 16.17 and later, bundled in release-please-action v4) replaces the YYYY-MM-DD on a line marked `x-release-please-date` with the day of the run. The date-released line in CITATION.cff now carries that annotation, so the date is written in the same Release PR commit as the version, and the workflow step that cloned the Release PR branch, ran sed and pushed a second commit is removed. Done: date-released follows each Release PR without the extra step. Next: check the date line in the next Release PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul · project thread
#35 added a workflow step that clones the Release PR branch, rewrites
date-releasedwithsedand pushes a second commit, because release-please was thought to have no date updater. It has one.CITATION.cff: thedate-releasedline carries# x-release-please-date..github/workflows/release-please.yml: the "Date CITATION.cff on the Release PR" step is removed.release-please's generic updater, which handles
CITATION.cffas anextra-filesentry, has an inlinedatescope since 16.17.0 (googleapis/release-please#2440, "feat: allow date updating in generic strategy"). From its source,src/updaters/generic.ts: "x-release-please-dateif this string is found on the line, then replace the date with the date of the last commit". In the code it replaces the firstYYYY-MM-DDon the line with the date of the run.release-please-action@v4depends onrelease-please ^17.3.0, so it has the updater. The date is now written in the Release PR commit itself, next to the version, with no extra commit or push; this is the same setup every kit now uses.Tests: the workflow and
CITATION.cffparse as YAML (Ruby Psych) with the same values; a Python emulation of the generic updater rewrites only the annotated date line (and the existing version line). The open Release PR still has the old step's commit; release-please rebuilds that branch on its next run.🤖 Generated with Claude Code