Repository navigation
fix: the typed-k and factors sheets keep their fields' and buttons' identifiers - #74
Merged
Merged
Conversation
…dentifiers The sheets' identifier sat on a plain VStack, so SwiftUI put it on every child and hid edx.typedK.source, edx.typedK.done, edx.factors.source and edx.factors.done. Each sheet is now one container element (as edx.room), whose children keep theirs. Fixes #73. Done: the sheets' children are findable. Next: mac4DSTEM's EDSJourney asserts them once this ships. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul
Fixes #73.
Break:
EDXTypedKSheetandEDXFactorsSheetput their identifier (edx.typedK,edx.factors) on a plainVStack. SwiftUI then gave it to every child and overrode the children's own:edx.typedK.source,edx.typedK.done,edx.factors.sourceandedx.factors.donecould not be found.Fix:
.accessibilityElement(children: .contain)before each sheet's identifier, asedx.roomalready does. Each sheet is one container element with its identifier, and its children keep theirs. Nothing drawn changes, and no numbers change.Test: a hosted unit test cannot see SwiftUI's accessibility nodes without a live client; both a view walk and an
accessibilityChildrenwalk returned nothing. So the check is a mac4DSTEM UI journey,EDSJourney.test3_TypedKSheetFieldsKeepTheirIdentifiers(openAlMgSi_4D_EDX.dm4, k-factors ▸ Typed, wait foredx.typedK.sourceandedx.typedK.done), run throughtools/run-tests.sh ui:The journey lands in mac4DSTEM after this ships (a draft PR there).
🤖 Generated with Claude Code