Repository navigation
test: busy line accessibility tests tick on a test clock - #76
Merged
Merged
Conversation
Both BusyLineAccessibilityTests started a wall clock and expected the first tick, read after a fixed 0.3 s spin, to say 0 s; a main thread a second late (a loaded runner, #70) made the first tick say 1 s or 2 s. The readouts now answer from a clock the test sets (0, then 2), and the test waits for the tick. A 1.5 s main-thread stall after the start reproduces both CI failures on the old tests and passes on the new. The later check is now exact. Fixes #75. Done: both tests deterministic under load. Next: nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul
Fixes #75.
Cause.
testTheBusyLineLabelFollowsTheTicksandtestTheInfobarReadoutLabelFollowsTheTickstookDate()as the run's start and expected the first tick, read after a fixedspin(0.3), to say "0 s". On a loaded runner the main thread reached the first TimelineView tick a second or more afterstart, so it said "1 s" / "2 s" (the #70 failures).Fix. Test-only. The
metrics/lineclosures answer from aTestClockthe test sets (0, then 2); the test spins the run loop until the expected tick lands (10 s timeout). The first check is still exact "0 s"; the later check tightens from "not 0 s / within one second of now" to exact "2 s", so the #39 regression (label stuck on the first tick) still fails.Fails before / passes after. With a 1.5 s
Thread.sleepinserted right after the start, the old tests fail with exactly the CI messages ("Disk detection · 2 s" vs "· 0 s", "1 s" vs "0 s"); the new tests pass with the same stall inserted.🤖 Generated with Claude Code