Repository navigation
test: pin auto ID on the demo pools (Ta never proposed, the Si and Ta tie, Mg and O below the loop bars) - #69
Merged
Merged
Conversation
… tie, Mg and O below the loop bars) Auto ID on the Poisson counts of the public AlMgSi demo pools (edx-demo-pools.json). The truth is planted on synthetic data: Al, Mg, Si, O, stray Cu K and sum peaks, no Ta. Test only, no number moves. - Ta is never proposed and never a sum-peak question on any of the five pools. The false Ta proposal of the demo run does not reproduce on the kit fixture at main: on recipe A, Ta M-alpha ties with Si for the 1.727 keV peak and both stay possible only. - Known issue (withKnownIssue): the planted Si is not proposed on recipe A because of that tie. - Mg and O in the matrix pools (planted near 1 L_D) are not nominated at the default bars. With the residual bar at 3 sigma and no low-energy factor, the matrix map nominates both, and both fail the gain bar of 100 at 1.0 and 2.1 L_D. The miss is the published loop bars, not a fit bias. Done: the two demo findings are pinned in DemoEDXAutoIDPinTests. Next: a loop change for the Si and Ta tie, after the open proposer PRs land. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paul · project thread
Part of #9
Test only; no number moves. This pins two findings from the demo run as a new test file,
DemoEDXAutoIDPinTests. Data: the public AlMgSi demo pools (edx-demo-pools.json), Poisson counts. The truth is planted on synthetic data: Al, Mg, Si, O, stray Cu K and sum peaks, and no Ta. Everything staysvalidation: "none".False Ta on an unclaimed Si K-alpha
ElementProposer().proposeOnRefinedAxisproposes no Ta on any of the five pools (L5, L6, L7, recipe A, matrix map), and Ta is never a sum-peak question. The 4.3 L_D Ta proposal from the demo run does not happen on the kit fixture at main e91a75a. The same holds on the feat: self-pair half bound on sum-peak questions and the opt-in overlap check #54 head, with the overlap check on or off.withKnownIssue: because of that tie, the planted Si is not proposed on recipe A. The Ta trial is not withheld by the confirmation rule. The fix is in the loop (ElementProposer.swift), and three open PRs already touch that file, so it waits.Mg and O missed in the matrix pools (planted near 1 L_D)
Test evidence
swift test -c release --parallel --num-workers 1 -j 1 --skip SpectroKitParityTests: green, 301 tests with 4 known issues (one of them new here), plus the other targets.Review: none. Test only, no numerics or public API change.
🤖 Generated with Claude Code