Skip to content

test: pin auto ID on the demo pools (Ta never proposed, the Si and Ta tie, Mg and O below the loop bars) - #69

Merged
Paullo9 merged 1 commit into
mainfrom
issue-9-demo-autoid-pins
Nov 1, 2026
Merged

Paullo9 merged 1 commit into
mainfrom
issue-9-demo-autoid-pins

Conversation

@Paullo9

@Paullo9 Paullo9 commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Requested by Paul · project thread

Part of #9

Test only; no number moves. This pins two findings from the demo run as a new test file, DemoEDXAutoIDPinTests. Data: the public AlMgSi demo pools (edx-demo-pools.json), Poisson counts. The truth is planted on synthetic data: Al, Mg, Si, O, stray Cu K and sum peaks, and no Ta. Everything stays validation: "none".

False Ta on an unclaimed Si K-alpha

  • ElementProposer().proposeOnRefinedAxis proposes no Ta on any of the five pools (L5, L6, L7, recipe A, matrix map), and Ta is never a sum-peak question. The 4.3 L_D Ta proposal from the demo run does not happen on the kit fixture at main e91a75a. The same holds on the feat: self-pair half bound on sum-peak questions and the opt-in overlap check #54 head, with the overlap check on or off.
  • Recipe A: Ta M-alpha (3.3 L_D) and Si K-alpha (4.4 L_D) tie for the 1.727 keV peak, and each reason names the other. Both stay possible only.
  • Known issue, pinned with withKnownIssue: because of that tie, the planted Si is not proposed on recipe A. The Ta trial is not withheld by the confirmation rule. The fix is in the loop (ElementProposer.swift), and three open PRs already touch that file, so it waits.

Mg and O missed in the matrix pools (planted near 1 L_D)

  • At the default bars neither element is a candidate on L5, recipe A or the matrix map.
  • The cheap experiment: drop the residual bar from 5 sigma to 3 sigma and the low-energy factor from 1.5 to 1. The matrix map then nominates Mg (1.03 L_D) and O (2.05 L_D), and both fail the gain bar ("improves the fit by 12" and "by 47", where a new element needs 100).
  • So the miss comes from the published loop bars, not from a fit bias. On the noise-free expected spectrum x100, every pool proposes Mg and O. The hypothesis would have been refuted if the two elements had stayed absent at the lower bar.

Test evidence

Review: none. Test only, no numerics or public API change.

🤖 Generated with Claude Code

… tie, Mg and O below the loop bars)

Auto ID on the Poisson counts of the public AlMgSi demo pools (edx-demo-pools.json). The truth is planted on
synthetic data: Al, Mg, Si, O, stray Cu K and sum peaks, no Ta. Test only, no number moves.

- Ta is never proposed and never a sum-peak question on any of the five pools. The false Ta proposal of the demo
  run does not reproduce on the kit fixture at main: on recipe A, Ta M-alpha ties with Si for the 1.727 keV peak
  and both stay possible only.
- Known issue (withKnownIssue): the planted Si is not proposed on recipe A because of that tie.
- Mg and O in the matrix pools (planted near 1 L_D) are not nominated at the default bars. With the residual bar at
  3 sigma and no low-energy factor, the matrix map nominates both, and both fail the gain bar of 100 at 1.0 and
  2.1 L_D. The miss is the published loop bars, not a fit bias.

Done: the two demo findings are pinned in DemoEDXAutoIDPinTests. Next: a loop change for the Si and Ta tie, after
the open proposer PRs land.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Paullo9 Paullo9 self-assigned this Oct 31, 2026
@Paullo9
Paullo9 merged commit 5cdcc80 into main Nov 1, 2026
7 checks passed
@Paullo9
Paullo9 deleted the issue-9-demo-autoid-pins branch November 1, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant